gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration. 

Test plan:

- Enable the system preference PatronSelfRegistration
- Make sure  PatronSelfRegistrationBorrowerUnwantedField does not
  contain cardnumber.
- Set the system preference  GDPR_Policy to "Enforce".
- In the OPAC click "Log in to your account" and "Register here".
- Fill out the form with valid data, but make sure you leave the
  checkbox under "GDPR consent" unchecked.
- Submit the form
- You will get back the form with the error message "You have not filled
  out all required fields. Please fill in all missing fields and
  resubmit."
- Without patch: cardnumber is not editable, and there is no input
  element for borrower_cardnumber (so the cardnumber will be lost when
  resubmitting the form)
- With patch: cardnumber is editable.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Andreas Jonsson 2021-08-31 12:50:03 +00:00 committed by Jonathan Druart
parent eefbe9bf3f
commit 075c8a96b3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
View File

@ -209,7 +209,7 @@
<label for="borrower_cardnumber" class="[% required.cardnumber | html %]">Library card number:</label>
[% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) %]
[% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) && action == 'edit' %]
[% borrower.cardnumber | html %]
[% ELSE %]
[% IF minlength_cardnumber == maxlength_cardnumber %]