gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24862: Regression tests 

This patch introduces tests for the expected behaviour on API routes
that expect a logged in user, but the request is made with an anonymous
session cookie.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail because the situation is not handled correctly in
the code

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomas Cohen Arazi 2020-03-13 11:44:03 -03:00 committed by Martin Renvoize
parent 6c3a2b4748
commit 0547ad34df
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
t/db_dependent/api/v1/auth_authenticate_api_request.t
View File

@ -100,7 +100,7 @@ subtest 'token-based tests' => sub {
subtest 'cookie-based tests' => sub {
plan tests => 5;
plan tests => 6;
$schema->storage->txn_begin;
@ -119,6 +119,25 @@ subtest 'cookie-based tests' => sub {
is( ref($user), 'Koha::Patron', 'Stashed koha.user object type is Koha::Patron') and
is( $user->borrowernumber, $borrowernumber, 'The stashed user is the right one' );
subtest 'logged-out tests' => sub {
plan tests => 3;
# Generate an anonymous session
my $session = C4::Auth::get_session('');
$session->param( 'ip', $remote_address );
$session->param( 'lasttime', time() );
$session->param( 'sessiontype', 'anon' );
$session->flush;
my $tx = $t->ua->build_tx( GET => '/api/v1/libraries' );
$tx->req->cookies({ name => 'CGISESSID', value => $session->id });
$tx->req->env({ REMOTE_ADDR => $remote_address });
$t->request_ok($tx)
->status_is( 401, 'Anonymous session on permission protected resource returns 401' )
->json_is( { error => 'Authentication failure.' } );
};
$schema->storage->txn_rollback;
};