From 043396c8aede76755c507474a094635534ddd905 Mon Sep 17 00:00:00 2001
From: Jan Kissig <bibliothek@th-wildau.de>
Date: Wed, 10 Jun 2026 20:31:01 +0000
Subject: [PATCH] Bug 42293: (QA follow-up) Fix hiding of additiona fields in
 serials-search

This fixes the hiding of additional fields in mana search by generating an array of additional field ids instead of calling To.json(additional_fields_for_subscription) which led to an Template process error.

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 .../prog/en/modules/serials/serials-search.tt          | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
index 1a5aae887d..58304e45f3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
@@ -1,5 +1,4 @@
 [% USE raw %]
-[% USE To %]
 [% USE Asset %]
 [% USE AuthorisedValues %]
 [% USE Branches %]
@@ -287,7 +286,10 @@
         const edit_action_link = "[% edit_action_link | html %]";
 
         [% IF mana %]
-            const additional_fields_for_subscription = [% To.json(additional_fields_for_subscription) | $raw %];
+            var additional_fields_for_subscription_ids = [];
+            [% FOR field IN additional_fields_for_subscription %]
+                additional_fields_for_subscription_ids.push([% field.id | $raw %]);
+            [% END %]
         [% END %]
     </script>
     [% Asset.js("js/serials-toolbar.js") | $raw %]
@@ -372,8 +374,8 @@
         <script nonce="[% Koha.CSPNonce | $raw %]">
             $(document).ready(function () {
                 $(".local").hide();
-                additional_fields_for_subscription.forEach(f => {
-                    $(`label[for=additional_field_${f.id}], input#additional_field_${f.id}`).hide();
+                additional_fields_for_subscription_ids.forEach(id => {
+                    $(`label[for=additional_field_${id}], input#additional_field_${id}`).hide();
                 });
             });
         </script>