gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30294: Rename Koha::Recall->* used relationship names 

This patch renames the underlaying relationship names used in the
'patron' and 'library' subs so they are more clearly prefetchable and
also enabling them to be embeddable and searchable through an eventual
API route for recalls.

To test:
1. Apply the patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Recall*
=> SUCCESS: Tests pass, nothing really changes
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Tomas Cohen Arazi 2022-03-14 14:47:36 -03:00 committed by Fridolin Somers
parent 78ecdc8439
commit 03ea475759
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Koha/Recall.pm
View File

@ -78,7 +78,7 @@ Returns the related Koha::Patron object for this recall.
sub patron {
my ( $self ) = @_;
my $patron_rs = $self->_result->borrower;
my $patron_rs = $self->_result->patron;
return unless $patron_rs;
return Koha::Patron->_new_from_dbic( $patron_rs );
}
@ -93,7 +93,7 @@ Returns the related Koha::Library object for this recall.
sub library {
my ( $self ) = @_;
my $library_rs = $self->_result->branch;
my $library_rs = $self->_result->library;
return unless $library_rs;
return Koha::Library->_new_from_dbic( $library_rs );
}

4
Koha/Schema/Result/Recall.pm
View File

@ -310,14 +310,14 @@ __PACKAGE__->belongs_to(
);
__PACKAGE__->belongs_to(
"borrower",
"patron",
"Koha::Schema::Result::Borrower",
{ borrowernumber => "borrowernumber" },
{ is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
);
__PACKAGE__->belongs_to(
"branch",
"library",
"Koha::Schema::Result::Branch",
{ branchcode => "branchcode" },
{