gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 26311: (follow-up) loop through the patron with date of birth and in categories having age limits 

Also added category limits in message, for example (12-18)

Check patron :
- with no date of birth
- with invalid age in category having age required
- with invalid age in category having upper age limit
- with invalid age in category having age required and upper age limit

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Fridolin Somers 2020-09-30 11:51:22 +02:00 committed by Tomas Cohen Arazi
parent 0151d5cd1f
commit 03b32e7a27
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
misc/maintenance/search_for_data_inconsistencies.pl
View File

@ -278,16 +278,34 @@ use C4::Biblio qw( GetMarcFromKohaField );
}
{
my $patrons = Koha::Patrons->search( {}, { order_by => [ 'categorycode', 'borrowernumber' ] } );
my $aging_patrons = Koha::Patrons->search(
{
-not => {
-or => {
'me.dateofbirth' => undef,
-and => {
'categorycode.dateofbirthrequired' => undef,
'categorycode.upperagelimit' => undef,
}
}
}
},
{ prefetch => ['categorycode'] },
{ order_by => [ 'me.categorycode', 'me.borrowernumber' ] },
);
my @invalid_patrons;
while ( my $patron = $patrons->next ) {
push @invalid_patrons, $patron unless $patron->is_valid_age;
while ( my $aging_patron = $aging_patrons->next ) {
push @invalid_patrons, $aging_patron unless $aging_patron->is_valid_age;
}
if (@invalid_patrons) {
new_section("Patrons with invalid age for category");
foreach my $patron (@invalid_patrons) {
new_item( sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s'",
$patron->borrowernumber, $patron->get_age, $patron->category->categorycode, );
foreach my $invalid_patron (@invalid_patrons) {
my $category = $invalid_patron->category;
new_item(
sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s' (%s-%s)",
$invalid_patron->borrowernumber, $invalid_patron->get_age, $category->categorycode,
$category->dateofbirthrequired, $category->upperagelimit
);
}
new_hint("You may change the patron's category automatically with misc/cronjobs/update_patrons_category.pl");
}