bug_6770: removed doubled override increment when using AllowHoldPolicyOverride

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This commit is contained in:
Srdjan Jankovic 2011-09-06 16:07:49 +12:00 committed by Chris Nighswonger
parent b340aa213e
commit 01d01b02a2
1 changed files with 6 additions and 10 deletions

View File

@ -432,22 +432,18 @@ foreach my $biblionumber (@biblionumbers) {
$policy_holdallowed = 0;
}
if (IsAvailableForItemLevelRequest($itemnumber) and
not $item->{cantreserve} and
CanItemBeReserved($borrowerinfo->{borrowernumber}, $itemnumber) ) {
if ( $policy_holdallowed ) {
if ( $policy_holdallowed &&
!$item->{cantreserve} &&
IsAvailableForItemLevelRequest($itemnumber) &&
CanItemBeReserved($borrowerinfo->{borrowernumber}, $itemnumber)
) {
$item->{available} = 1;
$num_available++;
}
} elsif (C4::Context->preference( 'AllowHoldPolicyOverride' ) ) {
# If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
$item->{override} = 1;
$num_override++;
}
# If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
if (C4::Context->preference( 'AllowHoldPolicyOverride' ) && !$item->{available} ) {
$item->{override} = 1;
$num_override++;
}
# If none of the conditions hold true, then neither override nor available is set and the item cannot be checked